Follow release reusables whose runner comes from _select-release-runner outputs - #8530
Merged
Conversation
…er outputs
The runner-group allow-list dropped
pytorch/pytorch/.github/workflows/_build-triton-wheel-linux.yml, so every
build-wheel-{cuda,aarch64,rocm,xpu} job in "Build Triton wheels" queued
indefinitely with runner_group_name "" (e.g. pytorch/pytorch run 31811475863,
40 jobs stuck).
collect_release_workflow_paths used two disagreeing notions of "release
related". Entry detection propagates the rel- signal through a local reusable,
so a workflow that calls _select-release-runner.yml is discovered. Edge
traversal, though, only followed a `uses:` when the *calling job body* held an
inline rel- label. pytorch/pytorch#193378 split the triton build into
_build-triton-wheel-linux.yml, called as:
build-wheel-cuda:
needs: select-runner
uses: ./.github/workflows/_build-triton-wheel-linux.yml
with:
runs_on: ${{ needs.select-runner.outputs.x86 }}
No inline label, so the edge was never taken and the reusable that actually
consumes the release runner never reached the allow-list. _binary-build-linux.yml
survived only because its generated caller still inlines the label in runs_on:.
Give both steps one definition of "runs on a release runner": an inline rel-
label, or a reference to the outputs of a job that calls a release-label
reusable. Sibling test/upload jobs still gate out, since they depend on the
build jobs rather than on the selector.
Dry-run against pytorch/pytorch over all seven target refs: 39 -> 40 entries,
the sole delta being _build-triton-wheel-linux.yml@refs/heads/main. Discovery on
the other six refs is unchanged, and per-ref discovery correctly omits the file
where it does not exist yet.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
huydhn
marked this pull request as ready for review
August 14, 2026 19:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_build-triton-wheel-linux.ymlnever made it into the release runner-group allow-list, so all 40build-wheel-{cuda,aarch64,rocm,xpu}jobs in "Build Triton wheels" satqueuedwithrunner_group_name: ""— see pytorch/pytorch run 31811475863.collect_release_workflow_pathsused two disagreeing notions of "release related":rel-signal through a local reusable, so a workflow calling_select-release-runner.ymlis discovered.build-triton-wheel.ymlwas.uses:when the calling job body held an inlinerel-label.pytorch/pytorch#193378 split the triton build into
_build-triton-wheel-linux.yml, invoked as:No inline label, so the edge was never taken and the reusable that actually consumes the release runner never reached the allow-list.
_binary-build-linux.ymlsurvived only incidentally: its generated caller still inlines the label inruns_on:.Testing
Run locally and https://github.com/pytorch/pytorch/actions/runs/31811475863/job/94802925779 is working now